netdev - Re: [iproute PATCH 0/5] warning-annoyance induced code-review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Nov 2015 11:51:51 -0800
From:	Stephen Hemminger <shemming@...cade.com>
To:	Phil Sutter <phil@....cc>
CC:	<netdev@...r.kernel.org>
Subject: Re: [iproute PATCH 0/5] warning-annoyance induced code-review

On Sat, 28 Nov 2015 01:00:00 +0100
Phil Sutter <phil@....cc> wrote:

> The primary goal was to get rid of the -Wunused-result warnings emitted
> during compiling. While adding the necessary checks, I found a few
> functions which could benefit from a bigger review (patches 1, 2 and 3).
> Patch 4 then adds the remaining missing checks, and patch 5 simplifies
> fgets() usage at a few spots.
> 
> Note that the last patch is my first Coccinelle-generated change, which
> makes me especially proud. Many thanks again to Julia Lawall for her kind
> support via IRC at this point!
> 
> Phil Sutter (5):
>   lnstat: review lnstat_update()
>   ss: reduce max indentation level in init_service_resolver()
>   ss: review is_ephemeral()
>   get rid of remaining -Wunused-result warnings
>   get rid of unnecessary fgets() buffer size limitation
> 
>  misc/arpd.c        |   2 +-
>  misc/ifstat.c      |   6 ++-
>  misc/lnstat_util.c |  21 +++++------
>  misc/nstat.c       |   6 ++-
>  misc/ss.c          | 107 ++++++++++++++++++++++++++++-------------------------
>  5 files changed, 74 insertions(+), 68 deletions(-)
> 

Applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html