lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Dec 2015 23:42:16 -0500 (EST) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: dvyukov@...gle.com, vyasevich@...il.com, yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org, edumazet@...gle.com Subject: Re: [PATCH net] ipv6: kill sk_dst_lock From: Eric Dumazet <eric.dumazet@...il.com> Date: Mon, 30 Nov 2015 08:35:15 -0800 > From: Eric Dumazet <edumazet@...gle.com> > > While testing the np->opt RCU conversion, I found that UDP/IPv6 was > using a mixture of xchg() and sk_dst_lock to protect concurrent changes > to sk->sk_dst_cache, leading to possible corruptions and crashes. > > ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest > way to fix the mess is to remove sk_dst_lock completely, as we did for > IPv4. > > __ip6_dst_store() and ip6_dst_store() share same implementation. > > sk_setup_caps() being called with socket lock being held or not, > we have to use sk_dst_set() instead of __sk_dst_set() > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Reported-by: Dmitry Vyukov <dvyukov@...gle.com> Please update the commit log message with the details you provided in a reply to this thread. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists