netdev - [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2015 17:44:02 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>
CC:	<netdev@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Andrew Lunn <andrew@...n.ch>
Subject: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

This file was originally cloned off of the MPC8641D-HPCN reference
platform, which actually had a PHY IRQ line connected.  However
this board does not.  The bogus entry was largely inert and went
undetected until commit 321beec5047af83db90c88114b7e664b156f49fe
("net: phy: Use interrupts when available in NOLINK state") was
added to the tree.

With the above commit, the board fails to NFS boot since it sits
waiting for a PHY IRQ event that of course never arrives.  Removing
the bogus entries from the DTS file fixes the issue.

Cc: Andrew Lunn <andrew@...n.ch>
Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
---
 arch/powerpc/boot/dts/sbc8641d.dts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/powerpc/boot/dts/sbc8641d.dts b/arch/powerpc/boot/dts/sbc8641d.dts
index 631ede72e226..68f0ed7626bd 100644
--- a/arch/powerpc/boot/dts/sbc8641d.dts
+++ b/arch/powerpc/boot/dts/sbc8641d.dts
@@ -227,23 +227,15 @@
 				reg = <0x520 0x20>;
 
 				phy0: ethernet-phy@1f {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <0x1f>;
 				};
 				phy1: ethernet-phy@0 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <0>;
 				};
 				phy2: ethernet-phy@1 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <1>;
 				};
 				phy3: ethernet-phy@2 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <2>;
 				};
 				tbi0: tbi-phy@11 {
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html