netdev - Re: [PATCH net-next v4 4/8] openvswitch: Update the CT state key only after nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2015 16:40:46 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jarno Rajahalme <jarno@....org>, netdev@...r.kernel.org
Cc:	netfilter-devel@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net-next v4 4/8] openvswitch: Update the CT state key only
 after nf_conntrack_in().

Hello.

On 12/9/2015 4:01 AM, Jarno Rajahalme wrote:

> Only a successful nf_conntrack_in() call can effect a connection state
> change, so if suffices to update the key only after the
> nf_conntrack_in() returns.
>
> This change is needed for the later NAT patches.
>
> Signed-off-by: Jarno Rajahalme <jarno@....org>
> ---
>   net/openvswitch/conntrack.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index a28a819..10f4a6e 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
> @@ -194,7 +194,6 @@ static int ovs_ct_set_mark(struct sk_buff *skb, struct sw_flow_key *key,
>   	struct nf_conn *ct;
>   	u32 new_mark;
>
> -

    Unrelated whitespace change?

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html