lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 Dec 2015 22:48:42 -0500 (EST) From: David Miller <davem@...emloft.net> To: peter@...ensteyn.nl Cc: hayeswang@...ltek.com, linux-usb@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, baolu.lu@...ux.intel.com Subject: Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled From: Peter Wu <peter@...ensteyn.nl> Date: Tue, 8 Dec 2015 12:17:42 +0100 > When an interface is brought up which was previously suspended (via > runtime PM), it would hang. This happens because napi_disable is called > before napi_enable. > > Solve this by avoiding napi_enable in the resume during open function > (netif_running is true when open is called, IFF_UP is set after a > successful open; netif_running is false when close is called, but IFF_UP > is then still set). > > While at it, remove WORK_ENABLE check from rtl8152_open (introduced with > the original change) because it cannot happen: > > - After this patch, runtime resume will not set it during rtl8152_open. > - When link is up, rtl8152_open is not called. > - When link is down during system/auto suspend/resume, it is not set. > > Fixes: 41cec84cf285 ("r8152: don't enable napi before rx ready") > Link: https://lkml.kernel.org/r/20151205105912.GA1766@al > Signed-off-by: Peter Wu <peter@...ensteyn.nl> > --- > v2: moved rtl_runtime_suspend_enable from close to rtl8152_suspend Applied, and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists