netdev - Re: [PATCH net-next v2 2/5] rhashtable: add function to replace an element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2015 13:38:41 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Tom Herbert <tom@...bertland.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Kernel Team <kernel-team@...com>
Subject: Re: [PATCH net-next v2 2/5] rhashtable: add function to replace an
 element

On Wed, Dec 09, 2015 at 10:43:23AM +0800, Herbert Xu wrote:
>
> OK after thinking about it a little bit more I think your approach
> is safe and we won't need to play any more games to get this to
> work.  So I'm fine with this patch.

One suggestion though: your inline function doesn't actually
inline the fast path.  The only thing that's inlined is the loop
which is not that critical.  As this is probably not performance
critical how about just making the whole thing out-of-line?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html