netdev - Re: [PATCH (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 20:09:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, alexandre.torgue@...com
Subject: Re: [PATCH (net-next.git) 16/18] stmmac: do not perform zero-copy
 for rx frames

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Wed, 9 Dec 2015 09:37:52 +0100

> @@ -98,6 +98,10 @@ static int buf_sz = DEFAULT_BUFSIZE;
>  module_param(buf_sz, int, S_IRUGO | S_IWUSR);
>  MODULE_PARM_DESC(buf_sz, "DMA buffer size");
>  
> +static int minrx = 256;
> +module_param(minrx, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(minrx, "Copy only tiny-frames");
> +

When you type module_param() in a network driver, you ought to receive
an electric shock in order to remind you that except in the most extreme
cases module parameters are absolutely not appropriate.

In this case we have an ethtool tunable people can use to control copy
break values like this, so use that instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html