netdev - Re: [PATCH V1 15/16] i40iw: add entry in rdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2015 10:24:02 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Faisal Latif <faisal.latif@...el.com>
CC:	"dledford@...hat.com" <dledford@...hat.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"e1000-rdma@...ts.sourceforge.net" <e1000-rdma@...ts.sourceforge.net>
Subject: Re: [PATCH V1 15/16] i40iw: add entry in rdma_netlink

On 12/24/2015 9:05 AM, Faisal Latif wrote:
>>
>> >Why the iwarp port mapper implementationhas to be repeated in each
>> >driver? can you join your code in a common place and avoid the duplication?
>> >
>> >root@...cs58 hw]# git grep RDMA_NL_ nes
>> >nes/nes.c:      [RDMA_NL_IWPM_REG_PID] = {.dump = iwpm_register_pid_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_ADD_MAPPING] = {.dump = iwpm_add_mapping_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_QUERY_MAPPING] = {.dump =
>> >iwpm_add_and_query_mapping_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_REMOTE_INFO] = {.dump = iwpm_remote_info_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_HANDLE_ERR] = {.dump = iwpm_mapping_error_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_MAPINFO] = {.dump = iwpm_mapping_info_cb},
>> >nes/nes.c:      [RDMA_NL_IWPM_MAPINFO_NUM] = {.dump =
>> >iwpm_ack_mapping_info_cb}
>> >nes/nes.c:      if (ibnl_add_client(RDMA_NL_NES, RDMA_NL_IWPM_NUM_OPS,
>> >nes_nl_cb_table))
>> >nes/nes.c:      ret = iwpm_init(RDMA_NL_NES);
>> >nes/nes.c:      ibnl_remove_client(RDMA_NL_NES);
>> >nes/nes.c:      ibnl_remove_client(RDMA_NL_NES);
>> >nes/nes.c:      iwpm_exit(RDMA_NL_NES);
>> >nes/nes_cm.c: &mapped_sockaddr, RDMA_NL_NES);
>> >nes/nes_cm.c:   return iwpm_remove_mapping(&local_sockaddr, RDMA_NL_NES);
>> >nes/nes_cm.c:                           &remote_addr, RDMA_NL_NES);
>> >nes/nes_cm.c:           iwpm_err = iwpm_register_pid(&pm_reg_msg,
>> >RDMA_NL_NES);
>> >nes/nes_cm.c:                   iwpm_err = iwpm_add_mapping(&pm_msg,
>> >RDMA_NL_NES);
>> >nes/nes_cm.c:   iwpm_err = iwpm_register_pid(&pm_reg_msg, RDMA_NL_NES);
>> >nes/nes_cm.c:           iwpm_err = iwpm_add_and_query_mapping(&pm_msg,
>> >RDMA_NL_NES);
>> >

>> i40iw iwarp driver registers with port mapper and uses its services. Beside that it is not the scope of the patch series.


You are asked a question by reviewer and your reply is

(1) YES, I did C & P from driver X to my driver

(2) explaining why C&P is right goes beyond the scope of reviewing my driver

This isn't how things work in upstream.

If needed, talk to the upstream Intel networking folks, they can assist 
you catching up on upstream practices.

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html