lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2015 21:57:12 -0500 (EST) From: David Miller <davem@...emloft.net> To: pshelar@...ira.com Cc: netdev@...r.kernel.org, nicolas.dichtel@...nd.com Subject: Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit() From: Pravin B Shelar <pshelar@...ira.com> Date: Wed, 23 Dec 2015 15:52:03 -0800 > } else { > - err_stats->tx_dropped++; > + struct net_device_stats *err_stats = &dev->stats; > + > + if (err < 0) { > + err_stats->tx_errors++; > + err_stats->tx_aborted_errors++; > + } else { > + err_stats->tx_dropped++; > + } The original code did not have this "tx_dropped" code path and you aren't explaining in your commit message why you are adding this new behavior. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists