netdev - Re: [PATCH net-next v2 05/10] be2net: log digital signature errors while flashing FW image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Dec 2015 16:23:13 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Sathya Perla <sathya.perla@...gotech.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 05/10] be2net: log digital signature errors
 while flashing FW image

Hi Suresh,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Sathya-Perla/be2net-patch-set/20151228-145423
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/emulex/benet/be_cmds.c: In function 'be_flash_skyhawk':
>> drivers/net/ethernet/emulex/benet/be_cmds.c:2963:4: warning: enumeration value 'MCC_ADDL_STATUS_INSUFFICIENT_RESOURCES' not handled in switch [-Wswitch]
       switch (addl_status(status)) {
       ^
>> drivers/net/ethernet/emulex/benet/be_cmds.c:2963:4: warning: enumeration value 'MCC_ADDL_STATUS_FLASH_IMAGE_CRC_MISMATCH' not handled in switch [-Wswitch]
>> drivers/net/ethernet/emulex/benet/be_cmds.c:2963:4: warning: enumeration value 'MCC_ADDL_STATUS_TOO_MANY_INTERFACES' not handled in switch [-Wswitch]
>> drivers/net/ethernet/emulex/benet/be_cmds.c:2963:4: warning: enumeration value 'MCC_ADDL_STATUS_INSUFFICIENT_VLANS' not handled in switch [-Wswitch]

vim +/MCC_ADDL_STATUS_INSUFFICIENT_RESOURCES +2963 drivers/net/ethernet/emulex/benet/be_cmds.c

  2947				flash_offset_support = false;
  2948				goto retry_flash;
  2949			}
  2950	
  2951			/* For old FW images ignore ILLEGAL_FIELD error or errors on
  2952			 * UFI_DIR region
  2953			 */
  2954			if (old_fw_img &&
  2955			    (base_status(status) == MCC_STATUS_ILLEGAL_FIELD ||
  2956			     (img_optype == OPTYPE_UFI_DIR &&
  2957			      base_status(status) == MCC_STATUS_FAILED))) {
  2958				continue;
  2959			} else if (status) {
  2960				dev_err(dev, "Flashing section type 0x%x failed\n",
  2961					img_type);
  2962	
> 2963				switch (addl_status(status)) {
  2964				case MCC_ADDL_STATUS_MISSING_SIGNATURE:
  2965					dev_err(dev,
  2966						"Digital signature missing in FW\n");
  2967					return -EINVAL;
  2968				case MCC_ADDL_STATUS_INVALID_SIGNATURE:
  2969					dev_err(dev,
  2970						"Invalid digital signature in FW\n");
  2971					return -EINVAL;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (51217 bytes)