lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jan 2016 14:32:33 +0800 From: Wengang Wang <wen.gang.wang@...cle.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] net: take care of bonding in build_skb_flow_key 在 2016年01月06日 14:18, David Miller 写道: > From: Wengang Wang <wen.gang.wang@...cle.com> > Date: Wed, 6 Jan 2016 13:49:28 +0800 > >> @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const struct sk_buff *skb, >> const struct sock *sk) >> { >> const struct iphdr *iph = ip_hdr(skb); >> - int oif = skb->dev->ifindex; >> + int oif; >> + struct net_device *master = NULL; >> + >> u8 tos = RT_TOS(iph->tos); >> u8 prot = iph->protocol; >> u32 mark = skb->mark; >> > Please fix the stlye of these variable declarations: > > 1) Order them from longest line to shortest line, also known > as "reverse christmas tree" layout. > > 2) Do not add an empty line in the middle of these variable > declarations. OK, will do in second drop. thanks, wengang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists