netdev - [patch -next] fsl/fman: use the ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2016 13:03:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Igal Liberman <igal.liberman@...escale.com>
Cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: [patch -next] fsl/fman: use the ALIGN() macro

The original code works fine but the issue is that static checkers
complain about this:

	~(u16)(OFFSET_UNITS - 1)

In that expression the cast to u16 is a no-op because we cast the value
15 to a u16 but then type promotion rules automatically cast it back to
an int and then we do the bitwise negate.

It's cleaner to use the kernel's ALIGN() macro instead.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
I think this patch is correct, but I haven't tested it, so please review
carefully.

diff --git a/drivers/net/ethernet/freescale/fman/fman_sp.c b/drivers/net/ethernet/freescale/fman/fman_sp.c
index f9e7aa3..b527da1 100644
--- a/drivers/net/ethernet/freescale/fman/fman_sp.c
+++ b/drivers/net/ethernet/freescale/fman/fman_sp.c
@@ -92,11 +92,8 @@ int fman_sp_build_buffer_struct(struct fman_sp_int_context_data_copy *
 	u32 tmp;
 
 	/* Align start of internal context data to 16 byte */
-	int_context_data_copy->ext_buf_offset = (u16)
-		((buffer_prefix_content->priv_data_size & (OFFSET_UNITS - 1)) ?
-		((buffer_prefix_content->priv_data_size + OFFSET_UNITS) &
-			~(u16)(OFFSET_UNITS - 1)) :
-		buffer_prefix_content->priv_data_size);
+	int_context_data_copy->ext_buf_offset =
+		(u16)ALIGN(buffer_prefix_content->priv_data_size, 16);
 
 	/* Translate margin and int_context params to FM parameters */
 	/* Initialize with illegal value. Later we'll set legal values. */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html