netdev - Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2016 11:22:22 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	kbuild-all@...org, davem@...emloft.net,
	alexei.starovoitov@...il.com, netdev@...r.kernel.org,
	Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix
 dev_forward_skb occasions

Hi Daniel,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Borkmann/bpf-add-skb_postpush_rcsum-and-fix-dev_forward_skb-occasions/20160107-090423
config: x86_64-lkp (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/net/sch_generic.h:8:0,
                    from include/linux/filter.h:16,
                    from include/net/sock.h:64,
                    from include/net/inet_sock.h:27,
                    from include/net/ip.h:30,
                    from net/core/filter.c:34:
   net/core/filter.c: In function 'bpf_clone_redirect':
>> net/core/filter.c:1530:19: error: 'struct sk_buff' has no member named 'tc_verd'
      if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
                      ^
   include/uapi/linux/pkt_cls.h:11:25: note: in definition of macro '_TC_MAKE32'
    #define _TC_MAKE32(x) ((x))
                            ^
   include/uapi/linux/pkt_cls.h:54:26: note: in expansion of macro '_TC_GETVALUE'
    #define G_TC_AT(x)       _TC_GETVALUE(x,S_TC_AT,M_TC_AT)
                             ^
   net/core/filter.c:1530:7: note: in expansion of macro 'G_TC_AT'
      if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
          ^
   net/core/filter.c: In function 'skb_do_redirect':
   net/core/filter.c:1578:18: error: 'struct sk_buff' has no member named 'tc_verd'
      if (G_TC_AT(skb->tc_verd) & AT_INGRESS)
                     ^
   include/uapi/linux/pkt_cls.h:11:25: note: in definition of macro '_TC_MAKE32'
    #define _TC_MAKE32(x) ((x))
                            ^
   include/uapi/linux/pkt_cls.h:54:26: note: in expansion of macro '_TC_GETVALUE'
    #define G_TC_AT(x)       _TC_GETVALUE(x,S_TC_AT,M_TC_AT)
                             ^
   net/core/filter.c:1578:7: note: in expansion of macro 'G_TC_AT'
      if (G_TC_AT(skb->tc_verd) & AT_INGRESS)
          ^

vim +1530 net/core/filter.c

  1524	
  1525		skb2 = skb_clone(skb, GFP_ATOMIC);
  1526		if (unlikely(!skb2))
  1527			return -ENOMEM;
  1528	
  1529		if (BPF_IS_REDIRECT_INGRESS(flags)) {
> 1530			if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
  1531				skb_postpush_rcsum(skb2, skb_mac_header(skb2),
  1532						   skb2->mac_len);
  1533			return dev_forward_skb(dev, skb2);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22219 bytes)