lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Jan 2016 18:33:00 +0800 From: Ming Lei <tom.leiming@...il.com> To: Martin KaFai Lau <kafai@...com> Cc: Network Development <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, FB Kernel Team <kernel-team@...com>, Alexei Starovoitov <alexei.starovoitov@...il.com> Subject: Re: [PATCH net-next 2/4] bpf: bpf_htab: Add BPF_MAP_TYPE_PERCPU_HASH On Fri, Jan 8, 2016 at 6:35 AM, Martin KaFai Lau <kafai@...com> wrote: > This patch adds BPFMAP_TYPE_PERCPU_HASH map type and its > htab_map_ops implementation. > > Signed-off-by: Martin KaFai Lau <kafai@...com> > --- > include/uapi/linux/bpf.h | 1 + > kernel/bpf/hashtab.c | 201 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 201 insertions(+), 1 deletion(-) ... > + > +/* Called from syscall or eBPF program */ > +static void *htab_percpu_map_lookup_elem(struct bpf_map *map, void *key) > +{ > + struct bpf_htab *htab = container_of(map, struct bpf_htab, map); > + struct htab_elem_common *l; > + > + l = __htab_map_lookup_elem(htab, key); > + if (l) { > + void *value = per_cpu_ptr(htab_percpu_elem(l)->value, > + smp_processor_id()); Then it isn't possible to retrieve the value of one key from all CPUs in eBPF prog, and that is definitely not flexible because update/delete element can be run from eBPF prog. And that is not a thing if using real_key and cpu_id, isn't it? Thanks,
Powered by blists - more mailing lists