netdev - Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2016 17:33:47 +0900
From:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
To:	Yuki Machida <machida.yuki@...fujitsu.com>, netdev@...r.kernel.org
Cc:	hideaki.yoshifuji@...aclelinux.com,
	Hangbin Liu <liuhangbin@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	"YOSHIFUJI Hideaki (USAGI Project)" <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

Hi,

Yuki Machida wrote:
> Hi, Yoshifuji-san
> 
> It is currently under investigation.
> It takes still time.
> 
> Futher comment below.
> 
> On 2016年01月05日 19:17, YOSHIFUJI Hideaki wrote:
>> Hi, Machida-san.
>>
>> Yuki Machida wrote:
>>> Please apply the following patch to v4.1.x.
>>>
>>> By ommit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface")
>>
>> s/ommit/commit/
> I will correct this typo.
> 
>>
>> Futher comment below.
>>
>> :
>>> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>>> Acked-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
>>> Signed-off-by: David S. Miller <davem@...emloft.net>
>>> ---
>>>   Documentation/networking/ip-sysctl.txt |  8 ++++++++
>>>   include/linux/ipv6.h                   |  1 +
>>>   include/uapi/linux/ipv6.h              |  1 +
>>>   net/ipv6/addrconf.c                    | 10 ++++++++++
>>>   net/ipv6/ndisc.c                       | 16 +++++++---------
>>>   5 files changed, 27 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>>> index 071fb18..07fad3d 100644
>> :
>>> --- a/include/uapi/linux/ipv6.h
>>> +++ b/include/uapi/linux/ipv6.h
>>> @@ -171,6 +171,7 @@ enum {
>>>   	DEVCONF_USE_OPTIMISTIC,
>>>   	DEVCONF_ACCEPT_RA_MTU,
>>>   	DEVCONF_STABLE_SECRET,
>>
>> You have to add a hole for DEVCONF_USE_OIF_ADDRS_ONLY.
> 
> For addition a hole of DEVCONF_USE_OIF_ADDRS_ONLY,
> It needs following two patches.
> commit 9131f3de24db4dc12199aede7d931e6703e97f3b
> commit 3985e8a3611a93bb36789f65db862e5700aab65e
> 
> When It apply two patches to 4.1.15,
> It doesn't conform to RFC 2460 and RFC 4443.
> (I used IPv6 Ready Logo Core Conformance Test.)
> I am looking for a patch for fix.

You do not have to implement that interface if you
do not need.  You just have to reserve that number
to maintain binary compatibility:
   :
   __DEVCONF_USE_OIF_ADDRS_ONLY,	/* not implemented */
   DEVCONF_ACCEPT_RA_MIN_HOP_LIMIT,
   DEVCONF_MAX

This is because those enums in include/"uapi"/linux/ipv6.h
are exported to userspace.

> 
>> --yoshfuji
>>
>>> +	DEVCONF_ACCEPT_RA_MIN_HOP_LIMIT,
>>>   	DEVCONF_MAX
>>>   };
>>>   
>>

-- 
Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION