lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Jan 2016 10:53:23 -0800 (PST) From: David Miller <davem@...emloft.net> To: vkuznets@...hat.com Cc: netdev@...r.kernel.org, kys@...rosoft.com, haiyangz@...rosoft.com, linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, eric.dumazet@...il.com, tom@...bertland.com, gnomes@...rguk.ukuu.org.uk Subject: Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation From: Vitaly Kuznetsov <vkuznets@...hat.com> Date: Mon, 25 Jan 2016 16:00:41 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netvsc_set_hash() function did some assumptions on the struct > flow_keys data layout and this is wrong. > > Get rid of netvsc_set_hash() by switching to skb_get_hash(). This change > will also imply switching to Jenkins hash from the currently used Toeplitz > but it seems there is no good excuse for Toeplitz to stay. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com> Applied.
Powered by blists - more mailing lists