lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jan 2016 16:51:38 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, aaro.koskinen@...ia.com, olof@...om.net Subject: Re: [PATCH net 1/2] of: of_mdio: Add a whitelist of PHY compatibilities. Hello. On 01/27/2016 03:11 AM, Andrew Lunn wrote: > Some phy nodes list a compatible value indicating the PHY make/model. > This is never used to match the device to the driver. However it does > confuse the code to separate a PHY from a generic MDIO device like a > switch. Generic MDIO devices must have a compatible value, PHYs can > list clause 22 or 45, but nothing else. > > Issue a warning if we find a compatible value known on the whitelist, My spell-checker trips on "whitelist"... Perhaps a space/hyphen needed? > and say it is a PHY. > > Fixes: a9049e0c513c ("mdio: Add support for mdio drivers.") > Reported-by: Aaro Koskinen <aaro.koskinen@...ia.com> > Reported-by: Olof Johansson <olof@...om.net> > Signed-off-by: Andrew Lunn <andrew@...n.ch> > --- > drivers/of/of_mdio.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index b5aa004a24b6..26c245041493 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -143,11 +143,31 @@ int of_mdio_parse_addr(struct device *dev, const struct device_node *np) > } > EXPORT_SYMBOL(of_mdio_parse_addr); > > +/* The following is a list of PHY compatible strings which appear in > + * some DTBs. The compatible string is never matched against a PHY > + * driver, so is pointless. We only expect devices which are not PHYs > + * to have a compatible string, so they can be matched to an MDIO > + * driver. Encourage users to upgrade there DT blobs to remove these. s/there/their/. [...] > @@ -166,6 +186,13 @@ static bool of_mdiobus_child_is_phy(struct device_node *child) > if (of_device_is_compatible(child, "ethernet-phy-ieee802.3-c22")) > return true; > > + if (of_match_node(whitelist_phys, child)) { > + pr_warn(FW_WARN > + "%s: Whitelisted compatible string. Please remove\n", White-listed? [...] MBR, Sergei
Powered by blists - more mailing lists