lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jan 2016 01:18:09 -0500 From: Jarod Wilson <jarod@...hat.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jiri Pirko <jiri@...lanox.com>, Daniel Borkmann <daniel@...earbox.net>, Tom Herbert <tom@...bertland.com>, Jay Vosburgh <j.vosburgh@...il.com>, Veaceslav Falico <vfalico@...il.com>, Andy Gospodarek <gospo@...ulusnetworks.com>, netdev@...r.kernel.org Subject: Re: [PATCH net 0/4] net: add rx_unhandled stat counter On Thu, Jan 28, 2016 at 01:02:15AM -0500, Jarod Wilson wrote: > On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote: > > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote: > > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > > index 289c231..7973ab5 100644 > > > --- a/include/linux/netdevice.h > > > +++ b/include/linux/netdevice.h > > > @@ -180,6 +180,7 @@ struct net_device_stats { > > > unsigned long tx_window_errors; > > > unsigned long rx_compressed; > > > unsigned long tx_compressed; > > > + unsigned long rx_unhandled; > > > }; > > > > > > > This structure is deprecated, please do not add new fields in it, > > as it will increase netlink answers for no good reason. > > > > rtnl_link_stats64 is what really matters these days. > > I'll respin the set without that Or not. Now I remember why I added that in the first place: In file included from ./arch/x86/include/asm/uaccess.h:7:0, from net/core/dev.c:75: net/core/dev.c: In function 'netdev_stats_to_stats64': include/linux/compiler.h:484:20: error: call to '__compiletime_assert_7263' declared with attribute error: BUILD_BUG_ON failed: sizeof(*stats64) != sizeof(*netdev_stats) prefix ## suffix(); \ ^ Things are actually hard-wired to require that addition at the moment, or you get the above build failure. Not sure if it's safe to remove that BUILD_BUG_ON() yet, haven't looked closely, it's past my bed time. :) -- Jarod Wilson jarod@...hat.com
Powered by blists - more mailing lists