netdev - Re: [PATCH] ipv4: ipconfig: avoid unused ic_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 16:11:44 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv4: ipconfig: avoid unused ic_proto_used symbol

Hello.

On 1/27/2016 4:53 PM, Arnd Bergmann wrote:

> When CONFIG_PROC_FS, CONFIG_IP_PNP_BOOTP, CONFIG_IP_PNP_DHCP and
> CONFIG_IP_PNP_RARP are all disabled, we get a warning about the
> ic_proto_used variable being unused:
>
> net/ipv4/ipconfig.c:146:12: error: 'ic_proto_used' defined but not used [-Werror=unused-variable]
>
> This avoids the warning, but making the definition conditional on

    s/but/by/?

> whether a dynamic IP configuration protocol is configured. If not,
> we know that the value is always zero, so we can optimize away the
> variable and all code that depends on it.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
[...]

MBR, Sergei