netdev - Re: [PATCH net] tcp: beware of alignments in tcp_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 22:50:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: beware of alignments in tcp_get_info()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 27 Jan 2016 10:52:43 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> With some combinations of user provided flags in netlink command,
> it is possible to call tcp_get_info() with a buffer that is not 8-bytes
> aligned.
> 
> It does matter on some arches, so we need to use put_unaligned() to
> store the u64 fields.
> 
> Current iproute2 package does not trigger this particular issue.
> 
> Fixes: 0df48c26d841 ("tcp: add tcpi_bytes_acked to tcp_info")
> Fixes: 977cb0ecf82e ("tcp: add pacing_rate information into tcp_info")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.