netdev - Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2016 10:08:38 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Stephen Hemminger <shemming@...cade.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"julien.floret@...nd.com" <julien.floret@...nd.com>
Subject: Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

On 02/02/2016 05:51 AM, Stephen Hemminger wrote:
> On Tue, 19 Jan 2016 11:01:45 +0000
> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
>
>> diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c
>> index 42c8841869f5..219ffa582c1a 100644
>> --- a/tc/tc_bpf.c
>> +++ b/tc/tc_bpf.c
>> @@ -49,6 +49,10 @@
>>   #include "tc_util.h"
>>   #include "tc_bpf.h"
>>
>> +#ifndef AF_ALG
>> +#define AF_ALG 38
>> +#endif
>
> Why is this here? AF_ALG is not used anywhere in this code.

It is used, this patch is fine as-is.

Thanks!

> Please remove it and resubmit