netdev - Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 13:56:16 +0100
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, Roopa Prabhu <roopa@...ulusnetworks.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] virtio_net: add ethtool support for set and get
 of settings

On 02/02/2016 01:51 PM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> This patch allows the user to set and retrieve speed and duplex of the
> virtio_net device via ethtool. Having this functionality is very helpful
> for simulating different environments and also enables the virtio_net
> device to participate in operations where proper speed and duplex are
> required (e.g. currently bonding lacp mode requires full duplex). Custom
> speed and duplex are not allowed, the user-supplied settings are validated
> before applying. Only full and unknown duplex are allowed to be set.
> 
> Example:
> $ ethtool eth1
> Settings for eth1:
> ...
> 	Speed: Unknown!
> 	Duplex: Unknown! (255)
> $ ethtool -s eth1 speed 1000 duplex full
> $ ethtool eth1
> Settings for eth1:
> ...
> 	Speed: 1000Mb/s
> 	Duplex: Full
> 
> Based on a patch by Roopa Prabhu.
> 
> CC: Roopa Prabhu <roopa@...ulusnetworks.com>
> CC: Michael S. Tsirkin <mst@...hat.com>
> CC: virtualization@...ts.linux-foundation.org
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> Allowed to set unknown speed/duplex if the user wants to reset them, though
> the user-space ethtool tool currently doesn't allow setting them.
> 

Since the speed can be anything maybe we should allow custom speeds after all ?
I wasn't sure about that so I added the validation.

Thanks,
 Nik