netdev - Re: [PATCH net-next v1 1/2] tipc: fix link attribute propagation bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Feb 2016 02:45:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	richard.alpe@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next v1 1/2] tipc: fix link attribute propagation
 bug

From: Richard Alpe <richard.alpe@...csson.com>
Date: Mon, 1 Feb 2016 08:19:56 +0100

> Changing certain link attributes (link tolerance and link priority)
> from the TIPC management tool is supposed to automatically take
> effect at both endpoints of the affected link.
> 
> Currently the media address is not instantiated for the link and is
> used uninstantiated when crafting protocol messages designated for the
> peer endpoint. This means that changing a link property currently
> results in the property being changed on the local machine but the
> protocol message designated for the peer gets lost. Resulting in
> property discrepancy between the endpoints.
> 
> In this patch we resolve this by using the media address from the
> link entry and using the bearer transmit function to send it. Hence,
> we can now eliminate the redundant function tipc_link_prot_xmit() and
> the redundant field tipc_link::media_addr.
> 
> Fixes: 2af5ae372a4b (tipc: clean up unused code and structures)
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
> Reported-by: Jason Hu <huzhijiang@...il.com>
> Signed-off-by: Richard Alpe <richard.alpe@...csson.com>

Applied.