lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 07 Feb 2016 14:19:11 -0500 (EST) From: David Miller <davem@...emloft.net> To: mahesh@...dewar.net Cc: maheshb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org Subject: Re: [PATCH next 2/3] ipvlan: mode is u16 From: Mahesh Bandewar <mahesh@...dewar.net> Date: Tue, 2 Feb 2016 11:20:30 -0800 > From: Mahesh Bandewar <maheshb@...gle.com> > > The mode argument was erronusly defined as u32 but it has always > been u16. > > Signed-off-by: Mahesh Bandewar <maheshb@...gle.com> This patch is changing more than this. Specifically it is invoking ipvlan_set_port_mode() instead of assigning port->mode directly in ipvlan_link_new(). That minimally needs to be documented in the commit log message. But I also wonder if for some reason in this conect the direct assignment happens to be fine. That's pretty much why you should explain things.
Powered by blists - more mailing lists