netdev - Re: [PATCH net-next 1/2] ethtool: make validate_speed accept all speeds between 0 and INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Feb 2016 23:26:18 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	davem@...emloft.net,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next 1/2] ethtool: make validate_speed accept all
 speeds between 0 and INT_MAX

On Sun, Feb 07, 2016 at 09:52:23PM +0100, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Devices these days can have any speed and as was recently pointed out
> any speed from 0 to INT_MAX is valid so adjust speed validation to
> accept such values.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  include/uapi/linux/ethtool.h | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 19676a420fe3..0c608192a4ef 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1321,24 +1321,7 @@ enum ethtool_sfeatures_retval_bits {
>  
>  static inline int ethtool_validate_speed(__u32 speed)
>  {
> -	switch (speed) {
> -	case SPEED_10:
> -	case SPEED_100:
> -	case SPEED_1000:
> -	case SPEED_2500:
> -	case SPEED_5000:
> -	case SPEED_10000:
> -	case SPEED_20000:
> -	case SPEED_25000:
> -	case SPEED_40000:
> -	case SPEED_50000:
> -	case SPEED_56000:
> -	case SPEED_100000:
> -	case SPEED_UNKNOWN:
> -		return 1;
> -	}
> -
> -	return 0;
> +	return speed <= INT_MAX || speed == SPEED_UNKNOWN;
>  }
>  
>  /* Duplex, half or full. */
> -- 
> 2.4.3