netdev - Re: [PATCH net-next 1/7] sock: struct proto hash function may error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2016 07:58:12 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Craig Gallek <kraigatgoog@...il.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/7] sock: struct proto hash function may error

Hi Craig,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT-for-TCP/20160210-074230
config: cris-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=cris 

All warnings (new ones prefixed by >>):

   In file included from net/ipv4/ip_forward.c:32:0:
   include/net/udp.h: In function 'udp_lib_hash':
>> include/net/udp.h:183:1: warning: no return statement in function returning non-void [-Wreturn-type]
--
   In file included from net/ipv4/ping.c:43:0:
   include/net/udp.h: In function 'udp_lib_hash':
>> include/net/udp.h:183:1: warning: no return statement in function returning non-void [-Wreturn-type]
   net/ipv4/ping.c: In function 'ping_common_sendmsg':
   net/ipv4/ping.c:692:21: warning: 'type' may be used uninitialized in this function [-Wuninitialized]
   net/ipv4/ping.c: In function 'ping_err':
   net/ipv4/ping.c:561:37: warning: 'code' may be used uninitialized in this function [-Wuninitialized]
   net/ipv4/ping.c:518:2: warning: 'type' may be used uninitialized in this function [-Wuninitialized]
   net/ipv4/ping.c:522:29: warning: 'icmph' may be used uninitialized in this function [-Wuninitialized]
   net/ipv4/ping.c:581:49: warning: 'family' may be used uninitialized in this function [-Wuninitialized]
--
   In file included from net/ipv4/esp4.c:19:0:
   include/net/udp.h: In function 'udp_lib_hash':
>> include/net/udp.h:183:1: warning: no return statement in function returning non-void [-Wreturn-type]
   net/ipv4/esp4.c: In function 'esp4_get_mtu':
   net/ipv4/esp4.c:509:31: warning: 'net_adj' may be used uninitialized in this function [-Wuninitialized]

vim +183 include/net/udp.h

57c67ff4b Tom Herbert   2014-08-22  167  	struct udphdr *uh;
57c67ff4b Tom Herbert   2014-08-22  168  	unsigned int hlen, off;
57c67ff4b Tom Herbert   2014-08-22  169  
57c67ff4b Tom Herbert   2014-08-22  170  	off  = skb_gro_offset(skb);
57c67ff4b Tom Herbert   2014-08-22  171  	hlen = off + sizeof(*uh);
57c67ff4b Tom Herbert   2014-08-22  172  	uh   = skb_gro_header_fast(skb, off);
57c67ff4b Tom Herbert   2014-08-22  173  	if (skb_gro_header_hard(skb, hlen))
57c67ff4b Tom Herbert   2014-08-22  174  		uh = skb_gro_header_slow(skb, hlen, off);
57c67ff4b Tom Herbert   2014-08-22  175  
57c67ff4b Tom Herbert   2014-08-22  176  	return uh;
57c67ff4b Tom Herbert   2014-08-22  177  }
57c67ff4b Tom Herbert   2014-08-22  178  
ba4e58eca Gerrit Renker 2006-11-27  179  /* hash routines shared between UDPv4/6 and UDP-Litev4/6 */
e5dcc1ba2 Craig Gallek  2016-02-09  180  static inline int udp_lib_hash(struct sock *sk)
ba4e58eca Gerrit Renker 2006-11-27  181  {
ba4e58eca Gerrit Renker 2006-11-27  182  	BUG();
ba4e58eca Gerrit Renker 2006-11-27 @183  }
ba4e58eca Gerrit Renker 2006-11-27  184  
1a50bd064 Joe Perches   2013-09-23  185  void udp_lib_unhash(struct sock *sk);
1a50bd064 Joe Perches   2013-09-23  186  void udp_lib_rehash(struct sock *sk, u16 new_hash);
ba4e58eca Gerrit Renker 2006-11-27  187  
ba4e58eca Gerrit Renker 2006-11-27  188  static inline void udp_lib_close(struct sock *sk, long timeout)
ba4e58eca Gerrit Renker 2006-11-27  189  {
ba4e58eca Gerrit Renker 2006-11-27  190  	sk_common_release(sk);
ba4e58eca Gerrit Renker 2006-11-27  191  }

:::::: The code at line 183 was first introduced by commit
:::::: ba4e58eca8aa9473b44fdfd312f26c4a2e7798b3 [NET]: Supporting UDP-Lite (RFC 3828) in Linux

:::::: TO: Gerrit Renker <gerrit@....abdn.ac.uk>
:::::: CC: David S. Miller <davem@...set.davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (37620 bytes)