netdev - Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 15:52:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Bryan.Whitehead@...rochip.com
Cc:	andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

From: <Bryan.Whitehead@...rochip.com>
Date: Tue, 16 Feb 2016 20:48:14 +0000

>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> Sent: Tuesday, February 16, 2016 3:44 PM
>> To: andrew@...n.ch
>> Cc: Bryan Whitehead - C21958; f.fainelli@...il.com; netdev@...r.kernel.org
>> Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver
>> 
>> From: Andrew Lunn <andrew@...n.ch>
>> Date: Tue, 16 Feb 2016 21:36:25 +0100
>> 
>> > So this is the discussion we need to have.
>> >
>> > The interface to the outside work is the two switch ports with real
>> > PHYs. What you are implementing is an Ethernet driver for an internal
>> > port connected to the switch. This port does not go to the outside
>> > world. This driver provides no way to control the ports to the outside
>> > world and you have no short term plan to actually implement control of
>> > the ports connected to the outside world.
>> >
>> > Should the Linux community accept this driver in this state?
>> >
>> > I would prefer to see a simple switchdev or DSA driver which exposes
>> > the two external ports.
>> 
>> I do not think, with all the infrastructure we have, that we should accept pure
>> ethernet drivers for such devices any more.
>> 
>> About year ago I would have responded differently, but these days all of the
>> necessary support and infrastructure is there, and reasonable easy for driver
>> authors to use.
> 
> I believe I can make the physical phys accessible through ethertool. Would that be reasonable?

No, we are asking you to implement DSA or switchdev support.