netdev - [PATCH] igmp: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 13:52:30 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: [PATCH] igmp: fix build warning

We were getting build warnings about:
net/ipv4/igmp.c: In function ‘igmp_group_added’:
net/ipv4/igmp.c:1227:14: warning: unused variable ‘net’ [-Wunused-variable]
		
net/ipv4/igmp.c: In function ‘ip_mc_inc_group’:
net/ipv4/igmp.c:1319:14: warning: unused variable ‘net’ [-Wunused-variable]

net/ipv4/igmp.c: In function ‘ip_mc_init_dev’:
net/ipv4/igmp.c:1646:14: warning: unused variable ‘net’ [-Wunused-variable]

net/ipv4/igmp.c: In function ‘ip_mc_up’:
net/ipv4/igmp.c:1665:14: warning: unused variable ‘net’ [-Wunused-variable]

These variables are only used when CONFIG_IP_MULTICAST is defined. Mark
them as '__maybe_unused'.

Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
---
 net/ipv4/igmp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 7c95335..0ba241b 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1224,7 +1224,7 @@ static void igmp_group_dropped(struct ip_mc_list *im)
 static void igmp_group_added(struct ip_mc_list *im)
 {
 	struct in_device *in_dev = im->interface;
-	struct net *net = dev_net(in_dev->dev);
+	struct net __maybe_unused *net = dev_net(in_dev->dev);
 
 	if (im->loaded == 0) {
 		im->loaded = 1;
@@ -1316,7 +1316,7 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
 void ip_mc_inc_group(struct in_device *in_dev, __be32 addr)
 {
 	struct ip_mc_list *im;
-	struct net *net = dev_net(in_dev->dev);
+	struct net __maybe_unused *net = dev_net(in_dev->dev);
 
 	ASSERT_RTNL();
 
@@ -1643,7 +1643,7 @@ void ip_mc_down(struct in_device *in_dev)
 
 void ip_mc_init_dev(struct in_device *in_dev)
 {
-	struct net *net = dev_net(in_dev->dev);
+	struct net __maybe_unused *net = dev_net(in_dev->dev);
 	ASSERT_RTNL();
 
 #ifdef CONFIG_IP_MULTICAST
@@ -1662,7 +1662,7 @@ void ip_mc_init_dev(struct in_device *in_dev)
 void ip_mc_up(struct in_device *in_dev)
 {
 	struct ip_mc_list *pmc;
-	struct net *net = dev_net(in_dev->dev);
+	struct net __maybe_unused *net = dev_net(in_dev->dev);
 
 	ASSERT_RTNL();
 
-- 
1.9.1