netdev - Re: [PATCH net-next] net: macb: make magic-packet property generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 17:23:47 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Sergio Prado <sergio.prado@...abworks.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	nicolas.ferre@...el.com, davem@...emloft.net,
	gregory.clement@...e-electrons.com, narmstrong@...libre.com,
	michal.simek@...inx.com, harini.katakam@...inx.com,
	boris.brezillon@...e-electrons.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: macb: make magic-packet property generic

Hello.

On 2/16/2016 3:13 AM, Sergio Prado wrote:

> Signed-off-by: Sergio Prado <sergio.prado@...abworks.com>
> ---
> As requested by Rob Herring on patch
> https://patchwork.ozlabs.org/patch/580862/
> ---
>   Documentation/devicetree/bindings/net/macb.txt | 2 +-
>   drivers/net/ethernet/cadence/macb.c            | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index c6b1cb5ffa87..b5a42df4c928 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,7 +25,7 @@ Required properties:
>
>   Optional properties for PHY child node:
>   - reset-gpios : Should specify the gpio for phy reset
> -- cdns,magic-packet : If present, indicates that the hardware supports waking
> +- magic-packet : If present, indicates that the hardware supports waking
>     up via magic packet.
>
>   Examples:
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 69af049e55a8..7ccf2298a5fa 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2929,7 +2929,7 @@ static int macb_probe(struct platform_device *pdev)
>   		bp->jumbo_max_len = macb_config->jumbo_max_len;
>
>   	bp->wol = 0;
> -	if (of_get_property(np, "cdns,magic-packet", NULL))
> +	if (of_get_property(np, "magic-packet", NULL))

    Could as well use of_property_read_bool().

[...]

MBR, Sergei