lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 16 Feb 2016 20:19:34 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/9] amd-xgbe: Disable VLAN filtering when
 in promiscuous mode

From: Tom Lendacky <thomas.lendacky@....com>
Date: Fri, 12 Feb 2016 08:32:24 -0600

> +#ifndef CRCPOLY_LE
> +#define CRCPOLY_LE 0xedb88320
> +#endif
> +static u32 xgbe_vid_crc32_le(__le16 vid_le)

Please do not implement yet another copy of a CRC implementation.

Make use of the various versions the kernel provides already instead,
add Kconfig dependencies as needed.

Thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ