netdev - Re: [net-next PATCH v2 5/8] net: tc: helper functions to query action types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 19:21:59 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
CC:	amir@...ai.me, jhs@...atatu.com, davem@...emloft.net,
	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH v2 5/8] net: tc: helper functions to query action
 types

On 16-02-16 12:26 PM, Jiri Pirko wrote:
> Tue, Feb 16, 2016 at 07:02:16AM CET, john.fastabend@...il.com wrote:
>> This is a helper function drivers can use to learn if the
>> action type is a drop action.
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>> ---
>> include/net/tc_act/tc_gact.h |   16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_gact.h
>> index 592a6bc..3067a10 100644
>> --- a/include/net/tc_act/tc_gact.h
>> +++ b/include/net/tc_act/tc_gact.h
>> @@ -2,6 +2,7 @@
>> #define __NET_TC_GACT_H
>>
>> #include <net/act_api.h>
>> +#include <linux/tc_act/tc_gact.h>
>>
>> struct tcf_gact {
>> 	struct tcf_common	common;
>> @@ -15,4 +16,19 @@ struct tcf_gact {
>> #define to_gact(a) \
>> 	container_of(a->priv, struct tcf_gact, common)
>>
>> +#ifdef CONFIG_NET_CLS_ACT
>> +static inline bool is_tcf_gact_dropped(const struct tc_action *a)
> 
> Meybe would be better to name this "is_tcf_gact_shot" for consistency?
> 

Agreed, its probably best to be consistent here. Thanks.