netdev - Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 14:00:04 +0200
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Tal Alon <talal@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Tariq Toukan <tariqt@...lanox.com>,
	Rana Shahout <ranas@...lanox.com>
Subject: Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

>>  struct mlx5e_priv {
>>         /* priv data path fields - start */
>> -       int                        default_vlan_prio;
>>         struct mlx5e_sq            **txq_to_sq_map;
>>         int channeltc_to_txq_map[MLX5E_MAX_NUM_CHANNELS][MLX5E_MAX_NUM_TC];
>>         /* priv data path fields - end */
>
>
> Didn't see a note on the removal of the default vlan prio in the
> change-log, could you elaborate what was the role of it before the
> patch and why we can just throw it?
>
it did nothing other than holding the number "0" which is always the
default prio for vlans
it was replaced with a the real 0 (the hardcoded "0") in the following lines:
+       int up = (netdev_get_num_tc(dev) && skb_vlan_tag_present(skb)) ?
+                skb->vlan_tci >> VLAN_PRIO_SHIFT : 0;

>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c
>> @@ -0,0 +1,184 @@
>> +/*
>> + * Copyright (c) 2015, Mellanox Technologies. All rights reserved.
>
> we're happily in 2016 (please fix here and also in other patches that
> introduce new files)
>

Ok.