netdev - Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 11:58:53 +0200
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Tal Alon <talal@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

On Wed, Feb 17, 2016 at 5:49 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Wed, Feb 17, 2016 at 2:07 PM, Saeed Mahameed
> <saeedm@....mellanox.co.il> wrote:
>> On Tue, Feb 16, 2016 at 11:38 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
>
>>>> -       for (tc = 0; tc < priv->params.num_tc; tc++) {
>>>> +       for (tc = 0; tc < MLX5E_MAX_NUM_TC; tc++) {
>>>>                 err = mlx5e_create_tis(priv, tc);
>
>>> various places in the patch use priv->params.num_tc, wasn't sure if
>>> it's correct to hard code things here, and if it does, why not hard
>>> code everywhere
>
>> TISs and TIRs unlike SQs and RQs are created once on driver load, so
>> we create the MAX supported TISs (TIS per prio)  and when you create
>> the rings/channels (SQs) we create them according to the dynamic
>> "priv->params.num_tc" and then we assign the pre allocated TIS to the
>> SQ according to SQ TC/Prio configuration.
>
> makes sense. Maybe spare few words on that in the change-log, or with
> a small comment
> in the code?

will add to change log.