netdev - Re: [PATCH]fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5].

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Feb 2016 15:52:33 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ken Kawasaki <ken_kawasaki@...ty.com>, netdev@...r.kernel.org
Subject: Re: [PATCH]fmvj18x_cs: The MAC address of FMV-J182 is stored at
 buf[5].

Hello.

On 2/19/2016 3:38 PM, Ken Kawasaki wrote:

> The MAC address of FMV-J182 is stored at buf[5].
>
> Signed-off-by: Ken Kawasaki <ken_kawasaki@...ty.com>
>
> ---
>
> --- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig	2016-02-19 20:48:40.143852346 +0900
> +++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c	2016-02-19 20:54:52.345568822 +0900
> @@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
>   		    goto failed;
>   	    }
>   	    /* Read MACID from CIS */
> -	    for (i = 5; i < 11; i++)
> -		    dev->dev_addr[i] = buf[i];
> +	    for (i = 0; i < 6; i++)
> +		    dev->dev_addr[i] = buf[i+5];

    Be consistent please, surround + with spaces.

[...]

MBR, Sergei