netdev - Re: [PATCH net] net/8021q: Check the correct vlan filter capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Feb 2016 16:49:34 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	saeedm@....mellanox.co.il
Cc:	saeedm@...lanox.com, netdev@...r.kernel.org, galp@...lanox.com,
	ogerlitz@...lanox.com, kaber@...sh.net
Subject: Re: [PATCH net] net/8021q: Check the correct vlan filter capability

From: Saeed Mahameed <saeedm@....mellanox.co.il>
Date: Wed, 24 Feb 2016 22:35:16 +0200

> BTW we choose the first option since the "buggy" function is called
> "vlan_hw_filter_capable" which lead us to decide that the function
> should be looking for ->hw_features and not ->features.
> and i think this way it makes more sense.

Again, anything doing checks on ->hw_features other than for the
purposes of the validation of a ->feature change is a bug.