netdev - Re: [PATCH] net/ethoc: do not free array priv->mdio->irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 15:27:28 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Colin King <colin.king@...onical.com>
Cc:	"David S . Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Tobias Klauser <tklauser@...tanz.ch>,
	Fabian Frederick <fabf@...net.be>,
	Max Filippov <jcmvbkbc@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ethoc: do not free array priv->mdio->irq

On Thu, Mar 03, 2016 at 01:43:34PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
> 
> Issue detected using static analysis with CoverityScan
> 
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/ethoc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
> index 62fa136..41b0106 100644
> --- a/drivers/net/ethernet/ethoc.c
> +++ b/drivers/net/ethernet/ethoc.c
> @@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
>  
>  		if (priv->mdio) {
>  			mdiobus_unregister(priv->mdio);
> -			kfree(priv->mdio->irq);
>  			mdiobus_free(priv->mdio);
>  		}
>  		if (priv->clk)
> -- 
> 2.7.0
>