netdev - Re: [iproute PATCH v2 06/20] iproute: TYPE keyword is not optional, fix help text accordingly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 16:05:57 +0100
From:	Phil Sutter <phil@....cc>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Stephen Hemminger <shemming@...cade.com>, netdev@...r.kernel.org
Subject: Re: [iproute PATCH v2 06/20] iproute: TYPE keyword is not optional,
 fix help text accordingly

On Thu, Mar 03, 2016 at 09:21:55AM -0500, Jamal Hadi Salim wrote:
> On 16-03-02 01:19 PM, Phil Sutter wrote:
> > +	fprintf(stderr, "          unreachable | prohibit | blackhole | nat }\n");
> 
> Dont think nat exists anymore...

But iproute2 seems to still support it? At least it's listed in
rtnl_rtntype_a2n().

The entry for RTN_NAT in net/ipv4/fib_semantics.c though looks like just
a stub. But at least it hasn't changed since the beginning of Git.
According to ip-route.8 it's indeed non-functional.

I only concerned help text and man page consistency, and since the man
page lists it (with a useful hint about it's state), the help text
should contain it either. Or do you think that's misleading?

Thanks, Phil