netdev - Re: [PATCH net-next V2 03/10] net/sched: Macro instead of CONFIG_NET_CLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 09:45:28 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Amir Vadai <amir@...ai.me>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	John Fastabend <john.r.fastabend@...el.com>,
	Jiri Pirko <jiri@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Hadar Har-Zion <hadarh@...lanox.com>,
	Rony Efraim <ronye@...lanox.com>
Subject: Re: [PATCH net-next V2 03/10] net/sched: Macro instead of
 CONFIG_NET_CLS_ACT ifdef

On Thu, Mar 3, 2016 at 6:55 AM, Amir Vadai <amir@...ai.me> wrote:
> Introduce the macros tc_no_actions and tc_for_each_action to make code
> clearer.
>
> Suggested-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Amir Vadai <amir@...ai.me>
> ---
>  include/net/act_api.h        | 21 ++++++++++++++++-----
>  include/net/tc_act/tc_gact.h |  4 ++--
>  2 files changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/include/net/act_api.h b/include/net/act_api.h
> index 342be6c..2a19fe1 100644
> --- a/include/net/act_api.h
> +++ b/include/net/act_api.h
> @@ -78,11 +78,6 @@ static inline void tcf_lastuse_update(struct tcf_t *tm)
>                 tm->lastuse = now;
>  }
>
> -#ifdef CONFIG_NET_CLS_ACT
> -
> -#define ACT_P_CREATED 1
> -#define ACT_P_DELETED 1
> -
>  struct tc_action {
>         void                    *priv;
>         const struct tc_action_ops      *ops;
> @@ -92,6 +87,11 @@ struct tc_action {
>         struct tcf_hashinfo     *hinfo;
>  };

You also expose struct tc_action out of CONFIG_NET_CLS_ACT,
which you never mention in your changelog at all.

So why?