netdev - Re: [PATCH 1/1] Fix bug where remove of device fails to free all resources.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2016 16:51:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dougmill@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, sathya.perla@...adcom.com,
	ajit.khaparde@...adcom.com, padmanabh.ratnakar@...adcom.com,
	sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com
Subject: Re: [PATCH 1/1] Fix bug where remove of device fails to free all
 resources.

From: Douglas Miller <dougmill@...ux.vnet.ibm.com>
Date: Tue,  1 Mar 2016 14:34:52 -0600

> The adapter->pcicfg resource is either mapped via pci_iomap() or
> derived from adapter->db. During be_remove() this resource was ignored
> and so could remain mapped after remove.
> 
> Add a flag to track whether adapter->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
> 
> Signed-off-by: Douglas Miller <dougmill@...ux.vnet.ibm.com>

You subject line need to mention the most relevant subsystem that your
change is too, otherwise people scanning the shortlog have no idea
where your change is taking place.

And your description needs to be more concise.

In this instance an appropriate Subject line would be:

	[PATCH] be2net: Don't leak iomapped memory on removal.

> @@ -5019,8 +5021,10 @@ static int be_map_pci_bars(struct be_adapter *adapter)
>  			if (!addr)
>  				goto pci_map_err;
>  			adapter->pcicfg = addr;
> +			adapter->pcicfg_mapped = 1;
>  		} else {
>  			adapter->pcicfg = adapter->db + SRIOV_VF_PCICFG_OFFSET;
> +			adapter->pcicfg_mapped = 0;
>  		}

Bool variables take on the values "true" and "false" so please use them.