netdev - Re: [PATCH RESEND] net:fec:Fix error checking in the function fec_enet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 6 Mar 2016 12:09:44 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	davem@...emloft.net, B38611@...escale.com, andrew@...n.ch,
	fabio.estevam@...escale.com, l.stach@...gutronix.de,
	rmk+kernel@....linux.org.uk, tremyfr@...il.com,
	johannes@...solutions.net, haokexin@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] net:fec:Fix error checking in the function
 fec_enet_init

Hello Nicholas,

On Fri, Mar 04, 2016 at 03:00:14PM -0500, Nicholas Krause wrote:
> This fixes error checking in the function fec_enet_init to properly
> check if the internal call to the function fec_enet_alloc_queue fails
> and if so immediately return the error code to the caller for it to
> handle it's own intended error paths.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

Looks right. There seem to be some more oportunities for similar
patches. E.g. if dmam_alloc_coherent fails the effects of
fec_enet_alloc_queue should be undone.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |