netdev - Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon,  7 Mar 2016 12:25:56 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Colin Ian King <colin.king@...onical.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	Priit Laes <plaes@...es.org>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is
 moreefficient


> From: Colin Ian King <colin.king@...onical.com>
> 
> passing rtl_stats by value is inefficient; the structure is over 300
> bytes in size and generally just one field (packet_report_type)
> is being accessed, so the pass by value is a relatively large overhead.
> This change just affects just the rx_command_packet calls.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo