netdev - Re: [PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Mar 2016 16:50:13 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jarno Rajahalme <jarno@....org>, netfilter-devel@...r.kernel.org
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c

Hello.

On 3/9/2016 3:24 AM, Jarno Rajahalme wrote:

> This makes the code easier to understand and the following patches
> more focused.
>
> Signed-off-by: Jarno Rajahalme <jarno@....org>
> ---
>   net/openvswitch/conntrack.c | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index 3045290..8cd0110 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
[...]
> @@ -418,6 +429,13 @@ static int ovs_ct_lookup(struct net *net, struct sw_flow_key *key,
>   {
>   	struct nf_conntrack_expect *exp;
>
> +	/* If we pass an expected packet through nf_conntrack_in() the
> +	 * expectiation is typically removed, but the packet could still be

    Expectation.
[...]

MBR, Sergei