netdev - Re: [PATCH net v3.16]r8169: Remove unsupported command on pci express

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2016 23:00:39 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Corcodel Marian <asd@...ian1000.go.ro>, netdev@...r.kernel.org
Subject: Re: [PATCH net v3.16]r8169: Remove unsupported command on pci express

Sergei Shtylyov <sergei.shtylyov@...entembedded.com> :
[...]
> >@@ -7083,8 +7084,11 @@ rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> >  	}
> >  	tp->mmio_addr = ioaddr;
> >
> >-	if (!pci_is_pcie(pdev))
> >+	if (!pci_is_pcie(pdev)) {
> >  		netif_info(tp, probe, dev, "not PCI Express\n");
> >+		tp->pcie = 0;
> >+	} else
> >+		tp->pcie = 1;
> 
>    Same question, you should assign true/false.

He should not bloat the private struct in the first place and the log
message adds no value but the change makes sense.

-- 
Ueimor