lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Mar 2016 17:09:56 +0100 From: Andrew Lunn <andrew@...n.ch> To: Ben Hutchings <ben@...adent.org.uk> Cc: netdev@...r.kernel.org Subject: Re: [PATCH ethtool 1/2] Remove short option -I for PHY statistics On Sun, Mar 13, 2016 at 04:01:20PM +0000, Ben Hutchings wrote: > It's not mnemonic and there's no requirement to have short options > for every command. > > Signed-off-by: Ben Hutchings <ben@...adent.org.uk> Reviewed-by: Andrew Lunn <andrew@...n.ch> Thanks Andrew > --- > ethtool.8.in | 4 ++-- > ethtool.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ethtool.8.in b/ethtool.8.in > index 2316556d65de..e44db99dc5d6 100644 > --- a/ethtool.8.in > +++ b/ethtool.8.in > @@ -220,7 +220,7 @@ ethtool \- query or control network driver and hardware settings > .B ethtool \-S|\-\-statistics > .I devname > .HP > -.B ethtool \-I|\-\-phy-statistics > +.B \-\-phy\-statistics > .I devname > .HP > .B ethtool \-t|\-\-test > @@ -495,7 +495,7 @@ auto-negotiation is enabled. > Queries the specified network device for NIC- and driver-specific > statistics. > .TP > -.B \-I \-\-phy\-statistics > +.B \-\-phy\-statistics > Queries the specified network device for PHY specific statistics. > .TP > .B \-t \-\-test > diff --git a/ethtool.c b/ethtool.c > index 480c14c8d30c..1c988f7d8a9d 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -4136,7 +4136,7 @@ static const struct option { > { "-t|--test", 1, do_test, "Execute adapter self test", > " [ online | offline | external_lb ]\n" }, > { "-S|--statistics", 1, do_gstats, "Show adapter statistics" }, > - { "-I|--phy-statistics", 1, do_gphystats, > + { "--phy-statistics", 1, do_gphystats, > "Show phy statistics" }, > { "-n|-u|--show-nfc|--show-ntuple", 1, do_grxclass, > "Show Rx network flow classification options or rules", >
Powered by blists - more mailing lists