| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Mar 2016 08:27:48 +0100
From: John Crispin <blogic@...nwrt.org>
To: Dan Carpenter <dan.carpenter@...cle.com>,
Felix Fietkau <nbd@...nwrt.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
On 15/03/2016 08:19, Dan Carpenter wrote:
> There was a missing unlock on the error path.
>
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
Acked-by: John Crispin <blogic@...nwrt.org>
Thanks !
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 9759fe5..c2c2e206 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -661,6 +661,8 @@ err_dma:
> itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
> } while (itxd != txd);
>
> + spin_unlock_irqrestore(ð->page_lock, flags);
> +
> return -ENOMEM;
> }
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
Powered by blists - more mailing lists