netdev - RE: [PATCH 2/2] lan78xx: add ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 16:11:05 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<sergei.shtylyov@...entembedded.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>
CC:	<UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH 2/2] lan78xx: add ndo_get_stats64

> > +	storage->rx_length_errors = (stats.rx_undersize_frame_errors +
> > +				     stats.rx_oversize_frame_errors);
> 
>     Parens not needed.
> 
> > +	storage->rx_errors = (stats.rx_fcs_errors +
> > +			      stats.rx_alignment_errors +
> > +			      stats.rx_fragment_errors +
> > +			      stats.rx_jabber_errors +
> > +			      stats.rx_undersize_frame_errors +
> > +			      stats.rx_oversize_frame_errors +
> > +			      stats.rx_dropped_frames);
> 
>     Neither here.
> 
> > +	storage->tx_errors = (stats.tx_fcs_errors +
> > +			      stats.tx_excess_deferral_errors +
> > +			      stats.tx_carrier_errors);
> 
>     And here.
> 

Thanks. Will resubmit.

Woojung