netdev - Re: [PATCH net v2] ppp: ensure file->private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 19:39:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	g.nault@...halink.fr
Cc:	netdev@...r.kernel.org, paulus@...ba.org, alan@...ux.intel.com
Subject: Re: [PATCH net v2] ppp: ensure file->private_data can't be
 overridden

From: Guillaume Nault <g.nault@...halink.fr>
Date: Mon, 14 Mar 2016 21:17:16 +0100

> Locking ppp_mutex must be done before dereferencing file->private_data,
> otherwise it could be modified before ppp_unattached_ioctl() takes the
> lock. This could lead ppp_unattached_ioctl() to override ->private_data,
> thus leaking reference to the ppp_file previously pointed to.
> 
> v2: lock all ppp_ioctl() instead of just checking private_data in
>     ppp_unattached_ioctl(), to avoid ambiguous behaviour.
> 
> Fixes: f3ff8a4d80e8 ("ppp: push BKL down into the driver")
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied and queued up for -stable, thanks!