netdev - Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 11:18:28 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Andreas Färber <afaerber@...e.de>
CC:	<netdev@...r.kernel.org>, <gabriel.fernandez@...aro.org>,
	<fschaefer.oss@...glemail.com>, <dinh.linux@...il.com>,
	<davem@...emloft.net>, <preid@...ctromag.com.au>,
	Tomeu Vizoso <tomeu@...euvizoso.net>
Subject: Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

Hi Andreas

On 3/16/2016 10:47 AM, Andreas Färber wrote:
> Hi Peppe,
>
> Am 15.03.2016 um 16:53 schrieb Giuseppe CAVALLARO:
>> On 3/15/2016 1:54 AM, Andreas Färber wrote:
>>> The connectivity issue still remains. Kernel log snippet:
>>>
>>> [  +0.001117] rk_gmac-dwmac ff290000.ethernet: Looking up phy-supply
>>> from device tree
>>> [  +0.000028] rk808 0-001b: Looking up vcc12-supply from device tree
>>> [  +0.000014] vcc_lan: supplied by vcc_io
>>> [  +0.000101] rk_gmac-dwmac ff290000.ethernet: clock input or output?
>>> (input).
>>> [  +0.000009] rk_gmac-dwmac ff290000.ethernet: TX delay(0x30).
>>> [  +0.000008] rk_gmac-dwmac ff290000.ethernet: RX delay(0x10).
>>> [  +0.000014] rk_gmac-dwmac ff290000.ethernet: init for RGMII
>>> [  +0.000104] rk_gmac-dwmac ff290000.ethernet: clock input from PHY
>>> [  +0.005063] rk_gmac-dwmac ff290000.ethernet: no reset control found
>>> [  +0.000007] stmmac - user ID: 0x10, Synopsys ID: 0x35
>>> [  +0.000002]  Ring mode enabled
>>> [  +0.000006]  DMA HW capability register supported
>>> [  +0.000000]  Normal descriptors
>>
>>                   ^^^^^^^^^^^^^^^^^^
>>
>>> [  +0.000003]  RX Checksum Offload Engine supported (type 2)
>>> [  +0.000002]  TX Checksum insertion supported
>>> [  +0.000002]  Wake-Up On Lan supported
>>> [  +0.000053]  Enable RX Mitigation via HW Watchdog Timer
>>> [  +0.000771] of_get_named_gpiod_flags: can't parse 'snps,reset-gpio'
>>> property of node '/ethernet@...90000[0]'
>>> [  +0.004250] libphy: stmmac: probed
>>> [  +0.000009] eth0: PHY ID 001cc915 at 0 IRQ POLL (stmmac-0:00) active
>>> [  +0.000005] eth0: PHY ID 001cc915 at 1 IRQ POLL (stmmac-0:01)
>>>
>>> As before, reverting "stmmac: first frame prep at the end of xmit
>>> routine" fixes it. My test cases are `ping 192.168.1.1` and `zypper up`.
>>
>> so on your side, this revert fixes the issue and you do not see any
>> tx watchdog as Tomeu's raised.
>
> Confirmed, the system ran stable over night. I don't use NFS on that
> system myself, having GMAC working only since v2.
>
>> I have fixed some problems on top of
>> "stmmac: first frame prep at the end of xmit ..." please
>> see patch attached for net-next.
>>
>> Indeed, the normal tx descriptors are well filled w/o
>> "stmmac: first frame prep at the end of xmit ..."
>>
>> I wonder if you could try the attachment in order to understand if we
>> have to  actually revert the patch (I ask you to not revert the
>> patch "stmmac: first frame...").
>
> Works great on top of next-20160314 with i2c plus this series, please
> add my Tested-by. Thanks a lot for investigating!

you are welcome, I have just sent the patch
   "[PATCH (net-next.git)] stmmac: fix TX normal DESC"
do not hesitate to contact me for further checks
and if I have missed something.

Cheers
peppe

>
> Cheers,
> Andreas
>