netdev - Re: [PATCH (net-next.git) 2/2] stmmac: fix MDIO settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 12:01:06 +0100
From:	Gabriel Fernandez <gabriel.fernandez@...aro.org>
To:	Giuseppe Cavallaro <peppe.cavallaro@...com>
Cc:	netdev@...r.kernel.org,
	Andreas Färber <afaerber@...e.de>,
	fschaefer.oss@...glemail.com, Dinh Nguyen <dinh.linux@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Phil Reid <preid@...ctromag.com.au>
Subject: Re: [PATCH (net-next.git) 2/2] stmmac: fix MDIO settings

Hi Pepe,

i have a kernel crash

[    2.714097] Unable to handle kernel NULL pointer dereference at
virtual address 000001d6
[    2.722188] pgd = c0204000
[    2.724886] [000001d6] *pgd=00000000
[    2.728452] Internal error: Oops: 5 [#1] SMP ARM
[    2.733054] Modules linked in:
[    2.736095] CPU: 1 PID: 1 Comm: swapper/0 Not tainted
4.5.0-rc7-01768-g3407893 #36
[    2.743649] Hardware name: STiH415/416 SoC with Flattened Device Tree
[    2.750074] task: ee070000 ti: ee05e000 task.ti: ee05e000
[    2.755467] PC is at stmmac_open+0xcc/0xc40
[    2.759641] LR is at of_phy_connect+0x44/0x5c


> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 4c5ce98..943500b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -278,7 +278,6 @@ static void stmmac_eee_ctrl_timer(unsigned long arg)
>   */
>  bool stmmac_eee_init(struct stmmac_priv *priv)
>  {
> -       char *phy_bus_name = priv->plat->phy_bus_name;
>         unsigned long flags;
>         bool ret = false;
>
> @@ -290,7 +289,7 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
>                 goto out;
>
>         /* Never init EEE in case of a switch is attached */
> -       if (phy_bus_name && (!strcmp(phy_bus_name, "fixed")))
> +       if (priv->phydev->is_pseudo_fixed_link)

priv->phydev is not yet affected
replace by if (phydev->is_pseudo_fixed_link) instead ?


Best Regard

Gabriel