netdev - Re: [PATCH net] tcp/dccp: remove obsolete WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 21:07:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, blazarus@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH net] tcp/dccp: remove obsolete WARN_ON() in icmp
 handlers

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 16 Mar 2016 22:52:15 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Now SYN_RECV request sockets are installed in ehash table, an ICMP
> handler can find a request socket while another cpu handles an incoming
> packet transforming this SYN_RECV request socket into an ESTABLISHED
> socket.
> 
> We need to remove the now obsolete WARN_ON(req->sk), since req->sk
> is set when a new child is created and added into listener accept queue.
> 
> If this race happens, the ICMP will do nothing special.
> 
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Ben Lazarus <blazarus@...gle.com>
> Reported-by: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable, thanks Eric.